Throw exception on migration failure to halt application

Also save migration configuration after each migration instead of at the end in case an exception is thrown part way through the list

1 files changed, 2 insertions, 6 deletions

diff --git a/Jellyfin.Server/Migrations/MigrationRunner.cs b/Jellyfin.Server/Migrations/MigrationRunner.cs
index 8bc29d8ac..0f9c2a391 100644
--- a/Jellyfin.Server/Migrations/MigrationRunner.cs
+++ b/Jellyfin.Server/Migrations/MigrationRunner.cs
@@ -59,16 +59,12 @@ namespace Jellyfin.Server.Migrations
                 catch (Exception ex)
                 {
                     logger.LogError(ex, "Could not apply migration {Name}", migrationRoutine.Name);
-                    continue;
+                    throw;
                 }
 
+                // Mark the migration as completed
                 logger.LogInformation("Migration {Name} applied successfully", migrationRoutine.Name);
                 applied.Add(migrationRoutine.Name);
-            }
-
-            if (applied.Count > migrationOptions.Applied.Length)
-            {
-                logger.LogInformation("Some migrations were run, saving the state");
                 migrationOptions.Applied = applied.ToArray();
                 host.ServerConfigurationManager.SaveConfiguration(MigrationsListStore.StoreKey, migrationOptions);
             }