diff options
| author | Joshua M. Boniface <joshua@boniface.me> | 2021-03-08 16:54:26 -0500 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2021-03-08 16:54:26 -0500 |
| commit | 0ef8bea1251632a6b94ffc187efe4c36d220fdde (patch) | |
| tree | 36e6db7655ba50fbda2d5a64fb44ef45bbd1fe4f | |
| parent | 82d88bdec6671fa6e89bf4e0844524799e9cbf11 (diff) | |
| parent | fcacae8cdeb3be15b27952d873ae08e29b6c7f94 (diff) | |
Merge pull request #5406 from cvium/trycleanstring-dont-die-on-me
| -rw-r--r-- | Emby.Naming/Video/CleanStringParser.cs | 8 | ||||
| -rw-r--r-- | tests/Jellyfin.Naming.Tests/Video/CleanStringTests.cs | 1 |
2 files changed, 8 insertions, 1 deletions
diff --git a/Emby.Naming/Video/CleanStringParser.cs b/Emby.Naming/Video/CleanStringParser.cs index 09a0cd189..bd7553a91 100644 --- a/Emby.Naming/Video/CleanStringParser.cs +++ b/Emby.Naming/Video/CleanStringParser.cs @@ -33,6 +33,12 @@ namespace Emby.Naming.Video private static bool TryClean(string name, Regex expression, out ReadOnlySpan<char> newName) { + if (string.IsNullOrEmpty(name)) + { + newName = ReadOnlySpan<char>.Empty; + return false; + } + var match = expression.Match(name); int index = match.Index; if (match.Success && index != 0) @@ -41,7 +47,7 @@ namespace Emby.Naming.Video return true; } - newName = string.Empty; + newName = ReadOnlySpan<char>.Empty; return false; } } diff --git a/tests/Jellyfin.Naming.Tests/Video/CleanStringTests.cs b/tests/Jellyfin.Naming.Tests/Video/CleanStringTests.cs index fde06c5a1..4b363843a 100644 --- a/tests/Jellyfin.Naming.Tests/Video/CleanStringTests.cs +++ b/tests/Jellyfin.Naming.Tests/Video/CleanStringTests.cs @@ -28,6 +28,7 @@ namespace Jellyfin.Naming.Tests.Video [InlineData("Crouching.Tiger.Hidden.Dragon.BDrip.mkv", "Crouching.Tiger.Hidden.Dragon")] [InlineData("Crouching.Tiger.Hidden.Dragon.BDrip-HDC.mkv", "Crouching.Tiger.Hidden.Dragon")] [InlineData("Crouching.Tiger.Hidden.Dragon.4K.UltraHD.HDR.BDrip-HDC.mkv", "Crouching.Tiger.Hidden.Dragon")] + [InlineData(null, null)] // FIXME: [InlineData("After The Sunset - [0004].mkv", "After The Sunset")] public void CleanStringTest(string input, string expectedName) { |