jellyfin/tests/Jellyfin.Server.Implementations.Tests, branch v12.0-rc5

Address review on MediaSourceCount batching

2026-08-08T16:33:11Z

Rename GetItemsWithAlternateVersions to GetItemIdsWithAlternateVersions across the interfaces and implementations since it returns ids. Return the hashset straight from the query instead of materializing an array first. Rename the DtoService guard to mayHaveAlternateVersions and invert it so the computed path is the explicit case. Assert the media source count value in the batch skip test and add a test covering an item that is in the returned set still resolving to the correct count.

Batch alternate version detection in DtoService to remove MediaSourceCount N+1

2026-08-08T02:51:45Z

Browsing a page of videos with the MediaSourceCount field ran one alternate version query per item, each opening a fresh DbContext. On a large library that turned a single page into hundreds of sequential round trips and made the Items endpoint take tens of seconds while holding a request thread the whole time. Detect which videos own alternate versions once per page with a single query, mirroring the existing people batch. Videos absent from that set have a single media source, so the per item lookups are skipped for the common case. Behavior is unchanged: a video with no alternates already resolved to a count of one. Adds a regression test asserting the count resolves from the batch and the per item lookups are never called.

Merge pull request #17571 from obiwantoby/perf/batch-people-dto

2026-08-08T01:43:21Z

Batch people lookups when building item DTOs

Merge pull request #17541 from vdatanet/fix/byname-total-record-count

2026-08-08T01:40:58Z

Fix by-name endpoints reporting TotalRecordCount=0 next to a populated Items array

Merge pull request #17555 from IDisposable/fix/reorder-update-items

2026-08-08T01:40:11Z

Delete old related info in bulk as late as possible in UpdateOrInsertItems

Merge pull request #17521 from Shadowghost/fix-plugin-disable

2026-08-08T01:39:39Z

Fix disabled plugins being re-enabled on restart

Batch people lookups when building item DTOs

2026-08-07T15:59:17Z

GetBaseItemDtos already batch fetches user data, child counts, played counts and artists before its per item loop, but AttachPeople still ran one GetPeople query per item. Rendering a page of items (for example a large playlist) fired one extra query per row. Add GetPeopleByItems to IPeopleRepository, which reads every requested item in a single query over the people mapping table and returns full PersonInfo (role, type and sort order) grouped by item id. GetBaseItemDtos prefetches this once when the People field is requested and passes it into AttachPeople, which reads from the batch instead of querying per item. The single item GetBaseItemDto path keeps its existing per item behaviour when no batch is supplied. Adds a DtoService test asserting people resolve from the batch and the per item GetPeople is never called.

Move the deletion of old related info to just before the save

2026-08-06T06:00:17Z

This makes the deletion of BaseItemProviders, BaseItemImageInfos, and BaseItemMetadataFields happen in batch as a contiguous block so the lock isn't held across items, just before the bulk SaveChanges.

Project the lowered person credit values once when updating people

2026-08-05T11:21:57Z

Fix by-name endpoints reporting TotalRecordCount=0 next to a populated Items array

2026-08-05T09:34:33Z

`GetItemValues` -- the shared path behind `/Artists`, `/AlbumArtists`, `/Genres`, `/MusicGenres` and `/Studios` -- disabled the total record count whenever the query carried no `Limit`: if (!filter.Limit.HasValue) { filter.EnableTotalRecordCount = false; } A request without an explicit limit therefore came back with N entries in `Items` and `TotalRecordCount = 0`. Clients that page on the reported total -- the documented contract every other list endpoint honours -- read that as an empty library. `/Items` and `/Persons` do not share this path and report the count correctly, which is what makes the inconsistency visible from the outside. Measured against master with a 62-track music library: GET /Artists?UserId=... -> TotalRecordCount=0 Items=5 GET /Artists?UserId=...&limit=100 -> TotalRecordCount=5 Items=5 Dropping the block costs nothing: `representativeIds` is materialised into a `List` a few lines below regardless, so `.Count` was already available and the count is now reported from it. Callers that genuinely want to skip the count still can -- `EnableTotalRecordCount = false` is honoured as before. The block also mutated the caller's own query object, so a query instance reused across calls silently lost its total after the first limitless one. That is covered by a test as well.