jellyfin/MediaBrowser.MediaEncoding/Subtitles, branch v12.0-rc3

Fix subtitle encoding for local files (#17281)

2026-07-21T12:52:59Z

* Fix subtitle encoding * Add short-circuit * Use IsTextFormat * Update MediaBrowser.MediaEncoding/Subtitles/SubtitleEncoder.cs Co-authored-by: Bond-009 --------- Co-authored-by: Bond-009

Merge pull request #17342 from LTe/fix-subtitle-conversion-race

2026-07-20T23:51:44Z

Fix race condition in concurrent subtitle conversion

Prevent ffmpeg from hanging extracting subtitles (#17297)

2026-07-17T21:23:57Z

* Prevent ffmpeg from hanging extracting subtitles Add `RunSubtitleExtractionProcess` to unify the external _ffmpeg_ process handling and error management. Add a `-nostdin` flag that prevents _ffmpeg_ from reading from _stdin_ and blocking on an inherited stdin handle (e.g. when Jellyfin runs as a service under NSSM), which otherwise hangs subtitle extraction forever when _ffmpeg_ blocks on any keyboard-interaction read until the timeout (30 minutes). Close the redirected _stdin_ to ensure immediage EOF. Drain the _stderr_ to a string and log it, to ensure we don't block the _ffmpeg_ process on errors that exceed the pipe length. Pass `-y` to _ffmpeg_ to ensure it overwrites any existing output file without prompting for confirmation. * Address review comments Make sure we always drain stderr. Make sure the timeout also honors the cancellationToken. Make sure when we get cancelled we don't log it as a ffmpeg error.

Fix race condition in concurrent subtitle conversion

2026-07-15T12:55:55Z

SubtitleEncoder.ConvertSubtitles parsed subtitles with libse's static Subtitle.Parse, which iterates a statically cached list of shared SubtitleFormat instances. Format parsers keep mutable per-parse state on the instance, so concurrent subtitle requests corrupted each other's output (cues mixed across streams and languages, truncated files) or failed with NullReferenceException when format detection broke down and Subtitle.Parse returned null. Parse through the injected ISubtitleParser instead. SubtitleEditParser instantiates a fresh format parser per call, so requests no longer share state. Its Parse method now returns the libse Subtitle directly (the SubtitleTrackInfo flattening was unused since the SubtitleEdit writer rework) so the writers keep full fidelity such as ASS styling.

Fix incorrect protocol used for subtitle charset detection

2026-07-11T21:33:06Z

Merge remote-tracking branch 'upstream/master' into fix-external-sub-invalidation

2026-06-05T21:41:05Z

Fix subtitle replacement not invalidating cache

2026-06-05T12:14:27Z

Prefer subtitle extension over codec

2026-06-01T18:57:59Z

Write subtitles using SubtitleEdit (#16805)

2026-06-01T17:43:57Z

* Write subtitles using SubtitleEdit We've been using SubtitleEdit to parse since 2021 https://github.com/jellyfin/jellyfin/pull/4984 I think it's time we start using it to write too * Clean up ConvertSubtitles * Add JsonWriter back

Add support for VobSub subtitle streams (#16552)

2026-05-31T15:18:25Z

* Add support for VobSub subtitle streams * update logic to determine separate extraction for VobSub subtitles * simplify VobSub extraction logic and fix ffmpeg command * Match `ExtractAllExtractableSubtitlesMKS` with `ExtractAllExtractableSubtitlesInternal` Matroska's VobSub option * Add a comments clarify why MKS was used, and remove the redundant VobSub extension branch * remove redundant VobSub format check * fix type errors