jellyfin/MediaBrowser.MediaEncoding/Subtitles/SubtitleEditParser.cs, branch v12.0-rc3

Fix race condition in concurrent subtitle conversion

2026-07-15T12:55:55Z

SubtitleEncoder.ConvertSubtitles parsed subtitles with libse's static Subtitle.Parse, which iterates a statically cached list of shared SubtitleFormat instances. Format parsers keep mutable per-parse state on the instance, so concurrent subtitle requests corrupted each other's output (cues mixed across streams and languages, truncated files) or failed with NullReferenceException when format detection broke down and Subtitle.Parse returned null. Parse through the injected ISubtitleParser instead. SubtitleEditParser instantiates a fresh format parser per call, so requests no longer share state. Its Parse method now returns the libse Subtitle directly (the SubtitleTrackInfo flattening was unused since the SubtitleEdit writer rework) so the writers keep full fidelity such as ASS styling.

Backport pull request #13384 from jellyfin/release-10.10.z

2025-02-03T21:59:08Z

Fix parallel use of not thread-safe SubtitleFormat instance Original-merge: 0b2a59e9631269c7e3261895e2e45d9dc07de848 Merged-by: joshuaboniface Backported-by: Bond_009

Add subtitle parser errors to log if available (#12479)

2024-09-06T13:47:06Z

Revert "Use System.Net.IPNetwork"

2023-11-14T20:16:33Z

This reverts commit 117d05d288da1d412159a29c0cb8d5c8259e48ae.

Remove redundant using directives

2022-09-28T14:26:03Z

Backport pull request #8087 from jellyfin/release-10.8.z

2022-08-01T18:25:42Z

feat: make subtitleeditparser generic Authored-by: Claus Vium Merged-by: Bond-009 Original-merge: 7323ccfc232d31797af3ceb8bad93cae1ea0898d

Address comments

2021-09-25T16:15:46Z

Target net6.0

2021-09-24T18:15:46Z

Fix namespace

2021-09-13T12:32:26Z

Move non-jellyfin extensions to separate project

2021-06-19T16:04:46Z