jellyfin/MediaBrowser.MediaEncoding/Subtitles/ISubtitleParser.cs, branch v12.0-rc3

Fix race condition in concurrent subtitle conversion

2026-07-15T12:55:55Z

SubtitleEncoder.ConvertSubtitles parsed subtitles with libse's static Subtitle.Parse, which iterates a statically cached list of shared SubtitleFormat instances. Format parsers keep mutable per-parse state on the instance, so concurrent subtitle requests corrupted each other's output (cues mixed across streams and languages, truncated files) or failed with NullReferenceException when format detection broke down and Subtitle.Parse returned null. Parse through the injected ISubtitleParser instead. SubtitleEditParser instantiates a fresh format parser per call, so requests no longer share state. Its Parse method now returns the libse Subtitle directly (the SubtitleTrackInfo flattening was unused since the SubtitleEdit writer rework) so the writers keep full fidelity such as ASS styling.

Backport pull request #8087 from jellyfin/release-10.8.z

2022-08-01T18:25:42Z

feat: make subtitleeditparser generic Authored-by: Claus Vium Merged-by: Bond-009 Original-merge: 7323ccfc232d31797af3ceb8bad93cae1ea0898d

Enable TreatWarningsAsErrors for MediaBrowser.MediaEncoding

2020-08-04T14:20:52Z

Find+Sed BOM removal *.cs: MediaBrowser.LocalMetadata-MediaBrowser.Model

2019-01-13T20:02:23Z

Port MediaEncoding and Api.Playback from 10e57ce8d21b4516733894075001819f3cd6db6b

2018-12-14T16:32:54Z

consolidate emby.server.core into emby.server.implementations

2017-08-09T19:56:38Z

update subtitle methods

2015-07-20T03:43:13Z

fixes #674 - Support converting subtitles to webvtt

2014-06-11T14:42:03Z

beginning remote subtitle downloading

2014-05-07T02:28:19Z

added subtitle parsing stubs

2014-05-05T14:45:45Z