jellyfin/MediaBrowser.Controller/Entities/PeopleHelper.cs, branch v12.0-rc1Unnamed repository; edit this file 'description' to name the repository.
https://git.b0n.dev/jellyfin/atom?h=v12.0-rc12025-02-04T01:48:59ZMerge branch 'master' into sort-nfo-data2025-02-04T01:48:59ZMarc BrooksIDisposable@gmail.com2025-02-04T01:48:59Zurn:sha1:e8cbcde02ebd930a5eeb6c95e0875a9e30acb3e8WIP porting new Repository structure2024-10-09T10:36:08ZJPVenson6794763+JPVenson@users.noreply.github.com2024-10-09T10:36:08Zurn:sha1:b09a41ad1f05664a6099734cb44e068f993a8e93Sort embedded collections in Nfo files2024-09-19T01:33:18ZMarc BrooksIDisposable@gmail.com2023-05-15T05:38:27Zurn:sha1:6dc61a430ba3a8480399309f277e5debfd6403ba
Because the Nfo files emit the collections as they are in-memory, the
files are not stable in format, genres, tags, albums, people, etc. are emitted in random orders. Add ordering of the collections when emitting the Nfo files so the file remains stable (unchanged) when underlying media information doesn't change.
In the process of this, it became clear that most of the providers and probes don't trim the strings like people's names, genre names, etc. so did a pass of Trim cleanup too.
Specific ordering: (alphabetical/numeric ascending after trimming blanks and defaulting to zero for missing numbers)
BaseItem: Directors, Writers, Trailers (by Url), Production Locations, Genres, Studios, Tags, Custom Provider Data (by key), Linked Children (by Path>LibraryItemId), Backdrop Images (by path), Actors (by SortOrder>Name)
AlbumNfo: Artists, Album Artists, Tracks (by ParentIndexNumber>IndexNumber>Name)
ArtistNfo: Albums (by Production Year>SortName>Name)
MovieNfo: Artists
Fix Debug build lint
Fix CI debug build lint issue.
Fix review issues
Fixed debug-build lint issues.
Emits the `disc` number to NFO for tracks with a non-zero ParentIndexNumber and only emit `position` if non-zero.
Removed the exception filtering I put in for testing.
Don't emit actors for MusicAlbums or MusicArtists
Swap from String.Trimmed() to ?.Trim()
Addressing PR feedback
Can't use ReadOnlySpan in an async method
Removed now-unused namespaceConvert Person.Type to use PersonKind enum (#9487)2023-03-25T17:52:02ZCody Robiberocody@robibe.ro2023-03-25T17:52:02Zurn:sha1:89be3aa37f89fcd91c2b68da07b5827510394141Use ArgumentException.ThrowIfNullOrEmpty2022-12-07T15:43:59ZBond_009bond.009@outlook.com2022-10-13T17:08:00Zurn:sha1:b366dc2e6e5be2b93f2b6fcc4549a32b655c3806Replace != null with is not null2022-12-05T14:01:13ZBond_009bond.009@outlook.com2022-12-05T14:01:13Zurn:sha1:52194f56b5f07e3ae01e2fb6d121452e37d1e93fReplace == null with is null2022-12-05T14:00:20ZBond_009bond.009@outlook.com2022-12-05T14:00:20Zurn:sha1:c7d50d640e614a3c13699e3041fbfcb258861c5aUse ArgumentNullException.ThrowIfNull helper method2022-10-06T18:21:23ZBond_009bond.009@outlook.com2022-10-06T18:21:23Zurn:sha1:a9a5fcde81060c9da2096235d61128006339a2ee
Did a simple search/replace on the whole repo (except the RSSDP project)
This reduces LOC and should improve performance (methods containing a throw statement don't get inlined)
```
if \((\w+) == null\)
\s+\{
\s+throw new ArgumentNullException\((.*)\);
\s+\}
```
```
ArgumentNullException.ThrowIfNull($1);
```
Remove dead code2021-05-05T12:45:08ZBond_009bond.009@outlook.com2021-05-05T12:45:08Zurn:sha1:787bcd4a83ea212e6ba4f93dcc4ce6788b950410Enable TreatWarningsAsErrors for MediaBrowser.Controller in Release2020-08-22T19:56:24ZBond_009bond.009@outlook.com2020-08-22T19:56:24Zurn:sha1:404bb4f83521760b3e9eeb748ab21d9056c4c023