Unnamed repository; edit this file 'description' to name the repository. https://git.b0n.dev/jellyfin/atom?h=v12.0-rc4 2026-07-25T16:52:51Z 2026-07-25T16:52:51Z Cody Robibero cody@robibe.ro 2026-07-25T16:52:51Z urn:sha1:7f26bd109171041f9e27a51f7cd3969fb2e8546d Fix incorrect year on local trailers 2026-07-22T06:09:33Z Shadowghost Ghost_of_Stone@web.de 2026-07-22T06:09:33Z urn:sha1:6382563440b69d816639abc2b4d03fca1d35eca2 2026-07-22T05:43:58Z Paolo Antinori pantinor@redhat.com 2026-07-21T06:20:40Z urn:sha1:5d580abb08d9d23f54e74050fdaa8fcdbc21571f A query sorted by a user-dependent key (PlayCount, IsFavoriteOrLiked, DatePlayed, IsPlayed, IsUnplayed) but carrying no User caused a NullReferenceException inside UserDataManager.GetUserData, surfacing as "Failed to compare two elements in the array" (InvalidOperationException wrapping the NRE from the LINQ sort) and 500-ing the /Items request. Root cause: LibraryManager.GetComparer assigned comparer.User = user without a null guard, so PlayCountComparer.GetValue called UserDataManager.GetUserData(null, item), dereferencing user.Id. Two-part fix: - LibraryManager.GetComparer: when user is null and the sort key requires a user (IUserBaseItemComparer), substitute the SortName comparer so the result stays deterministic instead of 500-ing. SortName is the project's canonical tiebreaker (ItemsController injects it for album-by-artist). - UserDataManager.GetUserData: ArgumentNullException.ThrowIfNull(user) as defense in depth (matches the existing guards on the SaveUserData overloads in the same file). On master this overload was rewritten to use ResolveUserDataRow, so the NRE dereferences user.Id rather than user.InternalId as on the release branch — same bug, different line. Also fixes DateLastMediaAddedComparer being statically mis-tagged as IUserBaseItemComparer: its GetDate is static and never reads User, so it does not need one. Without this, the SortName fallback above would wrongly engage for DateLastContentAdded on anonymous queries (returning SortName order instead of date order). Re-tagged to IBaseItemComparer and dropped the unused User/UserManager/UserDataManager properties. Tests: - UserDataManagerTests.GetUserData_NullUser_ThrowsArgumentNullException: reproduces the crash (NRE -> now ArgumentNullException). Added to master's existing UserDataManagerTests. - LibraryManagerSortTests.Sort_UserDependentKey_NullUser_FallsBackToSortNameWithoutThrowing: Sort with a user-dependent key + null user no longer throws and returns items ordered by the SortName fallback (direction preserved). - LibraryManagerSortTests.Sort_DateLastContentAdded_NullUser_OrdersByDateNotSortName: guards that DateLastContentAdded still sorts by date with no user (fixture chosen so date-desc and SortName-desc disagree, so a revert is caught). Full Jellyfin.Server.Implementations.Tests suite: 642 passed, 0 failed. Fixes #17393 2026-03-10T23:04:02Z theguymadmax theguymadmax@proton.me 2026-03-10T23:04:02Z urn:sha1:119b2e3d2ff275401870edb66ffcbb4569a9c678 2026-01-14T17:55:47Z Bond_009 bond.009@outlook.com 2025-11-16T18:31:45Z urn:sha1:098e8c6fed6aa1fd873f255b09b58e4780c087d6 2025-09-14T17:18:21Z Cody Robibero cody@robibe.ro 2025-09-14T17:18:21Z urn:sha1:4d36bd635d3dd0ff5652c1807dce7a1a1dff8873 2025-06-26T23:50:37Z Tim Eisele Ghost_of_Stone@web.de 2025-06-26T23:50:37Z urn:sha1:c6e568692ee14e66e6c844dc1e5481d705a096da 2025-05-09T14:35:29Z Tim Eisele Ghost_of_Stone@web.de 2025-05-09T14:35:29Z urn:sha1:49c6a99e00d5bef49c4154a5a9500f39b84cc32e 2025-03-31T03:51:54Z Tim Eisele Ghost_of_Stone@web.de 2025-03-31T03:51:54Z urn:sha1:3fc3b04daf929d1d3a9533fc410cb77885eb2e8a 2025-03-25T15:45:00Z JPVenson github@jpb.email 2025-03-25T15:45:00Z urn:sha1:42bdb22bfb690a6af37d70f12844881d884927b1